Add support for GitHub Enterprise URLs in manifest#100
Add support for GitHub Enterprise URLs in manifest#100inidona wants to merge 3 commits intoxthexder:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an additional URL match pattern to the browser extension manifests to load the content script on a GitHub Enterprise-related domain pattern.
Changes:
- Update Chrome (MV3) manifest
content_scripts.matchesto includehttps://*.ghe.com/* - Update Firefox (MV2) manifest
content_scripts.matchesto includehttps://*.ghe.com/*
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| chrome/manifest.json | Extends content script URL match list with a *.ghe.com pattern |
| mozilla/manifest.json | Extends content script URL match list with a *.ghe.com pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "content_scripts": [ | ||
| { | ||
| "matches": ["https://github.com/*", "https://gist.github.com/*"], | ||
| "matches": ["https://github.com/*", "https://gist.github.com/*", "https://*.ghe.com/*"], |
There was a problem hiding this comment.
The added match pattern only covers subdomains of ghe.com (and not ghe.com itself), and it likely won’t satisfy the stated goal of “GitHub Enterprise URLs” since most Enterprise Server instances run on arbitrary custom hostnames (e.g., github.company.com). Consider either adding an explicit pattern for https://ghe.com/* (if desired) and/or switching to a configurable/optional host permission + dynamic script injection approach so users can add their own Enterprise domain(s).
| "content_scripts": [ | ||
| { | ||
| "matches": ["https://github.com/*", "https://gist.github.com/*"], | ||
| "matches": ["https://github.com/*", "https://gist.github.com/*", "https://*.ghe.com/*"], |
There was a problem hiding this comment.
The added match pattern only covers subdomains of ghe.com (and not ghe.com itself), and it likely won’t satisfy the stated goal of “GitHub Enterprise URLs” since most Enterprise Server instances run on arbitrary custom hostnames (e.g., github.company.com). Consider either adding an explicit pattern for https://ghe.com/* (if desired) and/or switching to a configurable/optional host permission + dynamic script injection approach so users can add their own Enterprise domain(s).
|
#9 should fix if using a subdomain of ghe.com |
1 participant
Hi, would be very helpfull if you can check this and publish it to the browsers